Modified the trustymail code to handle SPF redirects #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-m-f-t
reviewed
Nov 22, 2017
| domain.syntax_errors.append(error.msg) | ||
|
|
||
|
|
||
| def get_spf_record_text(resolver, domain_name, domain, follow_redirect=False): |
There was a problem hiding this comment.
Should follow_redirect default to True?
There was a problem hiding this comment.
See my comments below, in the spf_scan function.
jsf9k
commented
Nov 22, 2017
| """ | ||
| # If an SPF record exists, record the raw SPF record text in the | ||
| # Domain object | ||
| record_text_not_following_redirect = get_spf_record_text(resolver, domain.domain_name, domain) |
There was a problem hiding this comment.
get_spf_record_text is called with follow_redirect=False here because we want the SPF record that directly corresponds to domain.domain_name. We stash this value inside of domain.spf on line 291.
jsf9k
commented
Nov 22, 2017
| if record_text_not_following_redirect: | ||
| domain.spf.append(record_text_not_following_redirect) | ||
|
|
||
| record_text_following_redirect = get_spf_record_text(resolver, domain.domain_name, domain, True) |
There was a problem hiding this comment.
get_spf_record_text is called with follow_redirect=True here because we want to follow the redirects until we get an SPF record that we can use to determine the expected behavior when we run spf.check() inside of the check_spf_record function on line 198.
h-m-f-t
approved these changes
Nov 27, 2017
|
👍 🇺🇸 |
mcdonnnj
pushed a commit
that referenced
this pull request
Jan 23, 2023
…m-forked-repos Make workflow run when a PR is opened, synchronized, or reopened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a bigger change than it is because I:
spf_scan()function up into three separate functionsThis will resolve #7.